Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PER-194] : Esignet Mock IDA performance script #1037

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

nihallakshmankonchady
Copy link

The files added in this PR.

  • Esignetmockida_Test_Script.jmx : JMeter script for performance execution
  • realistic_names_list.csv : Names required to create identities
  • ReadMe file : Instruction for performance test execution.

Nihal LK added 5 commits December 9, 2024 17:03
Signed-off-by: Nihal LK <[email protected]>
Signed-off-by: Nihal LK <[email protected]>
Signed-off-by: Nihal LK <[email protected]>
Signed-off-by: Nihal LK <[email protected]>
@akhilmoogi
Copy link

@nihallakshmankonchady Rename the script from Esignetmockida_Test_Script.jmx to Esignet_Mockida_Test_Script.jmx

@akhilmoogi
Copy link

S01 OTP authentication (Execution) - In transaction controller change the name S01 T05 Authorisation to S01 T05 Authorization

@akhilmoogi
Copy link

PMS OIDC Client POST Endpoint - remove POST

@akhilmoogi
Copy link

In read me file also chnage this name as mentioned in above comment (Esignetmockida_Test_Script.jmx)

<jmeterTestPlan version="1.2" properties="5.0" jmeter="5.3">
<hashTree>
<TestPlan guiclass="TestPlanGui" testclass="TestPlan" testname="Test Plan" enabled="true">
<stringProp name="TestPlan.comments"></stringProp>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User Defined Variables:

  1. Why we have acrValuesPwd ? As per the scope it is only otp based auth right.
  2. In case of this mock script, we don't have pms in the dependent service, why do we have pmsClientId and other properties ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishwa-vyom

  1. We have changed acrValuesPwd to acrValuesOtp specifically pointing to OTP authentication.
  2. Client ID generated by eSignet needs auth token generated by PMS client.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nihallakshmankonchady In that case kindly add PMS details in the request sheet as well. As there is a dependency on that.

Copy link
Member

@vishwa-vyom vishwa-vyom Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Point 1 is fine.
On Point 2, If the eSignet mock setup is enabled with authentication, we need a clientId and secret key to generate the access token. It is not necessary to the PMS client id, it can be any client id with the proper roles.
So, doing this auth token generation is fine, but lets not call that clientId and secret key as pms anywhere, since mock is not directly / indirectly dependent on PMS.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have removed Auth token generation as well as PMS dependency.

<stringProp name="TestPlan.comments"></stringProp>
<boolProp name="TestPlan.functional_mode">false</boolProp>
<boolProp name="TestPlan.tearDown_on_shutdown">true</boolProp>
<boolProp name="TestPlan.serialize_threadgroups">false</boolProp>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Generate PMS Auth Token Endpoint" to be removed, because the PMS is again not in scope for eSignet with mock testing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Create OIDC Client in MOSIP Authentication System (Setup)" also be changed to call the eSignet API directly to create the client id

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Auth Token is generated by Generate PMS Auth Token Endpoint is passed in header file of eSignet client ID API. Hence we cant remove Generate PMS Auth Token Endpoint .
  2. Changed from Create OIDC Client in MOSIP Authentication System (Setup) to Create OIDC Client in Mock Authentication System (Setup). And updated with eSignet API to generate client ID.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Point 2 is fine
Point 1, If the eSignet mock setup is enabled with authentication, we need a clientId and secret key to generate the access token. It is not necessary to the PMS client id, it can be any client id with the proper roles.
So, doing this auth token generation is fine, but lets not call that clientId and secret key as pms anywhere, since mock is not directly / indirectly dependent on PMS. (Please recheck on the authentication requirement with Anusha once again)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have removed Auth token generation as well as PMS dependency.


* eSignet-default properties: eSignet will be pointing to MockIDA services after performing following changes
*mosip.esignet.integration.authenticator=MockAuthenticationService
*mosip.esignet.integration.key-binder=MockKeyBindingWrapperService
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be mention about the plugin part also

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishwa-vyom ,
We have added the plugin details in readme file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the plugin details

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was mentioning about the eSignet plugin configuration to use the mock plugin for this script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants