-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INJICERT-657] Added DB upgrade scripts for release #146
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Piyush7034 <[email protected]>
Signed-off-by: Piyush7034 <[email protected]>
COMMENT ON COLUMN svg_template.context IS 'VC Context: Context URL list items separated by comma(,)'; | ||
COMMENT ON COLUMN svg_template.credential_type IS 'Credential Type: Credential type list items separated by comma(,)'; | ||
COMMENT ON COLUMN svg_template.template IS 'Template Content: Velocity Template to generate the VC'; | ||
COMMENT ON COLUMN svg_template.cr_dtimes IS 'Date when the template was inserted in table.'; | ||
COMMENT ON COLUMN svg_template.upd_dtimes IS 'Date when the template was last updated in table.'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the table name is template_data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed template name
f3bc97e
to
e7ae5df
Compare
@@ -0,0 +1,33 @@ | |||
\c inji_certify | |||
|
|||
CREATE TABLE svg_template ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we rename this to rendering template?
the type of image used here is svg, it can be changed as well right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with additional field designating the type of template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes have to be merged in release branch also and there are templates and repositories associated with this table. Can these changes be taken up for the next release? @vharsh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're a bit late in designing this template as this change has also gone to released
and collab
, hence I suggest this to be taken up in next release if possible.
README.md
Outdated
1. Create the tables with all the fields that should be returned by the Postgres Data Provider Plugin within the certify postgres database. | ||
- Refer the following query for insertion in DB: | ||
``` | ||
CREATE TABLE certify.<table_name> ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we finalizing this design for certify pg plugin?
data present within certify DB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doc refers to the configuration setup for postgres plugin as requested by Likhitha. So it was suggested to add this in the certify docs for reference. This should be updated based on future changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but this is being given as a handover to the QA team and a minimal documentation is required for the same, can we drop this plugin from the scope?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This document is now moved to digital-credential-plugins repo under postgres-dataprovider-plugin project as suggested by @vishwa-vyom
Signed-off-by: Piyush7034 <[email protected]>
e7ae5df
to
30efe6c
Compare
Signed-off-by: Piyush7034 <[email protected]>
Signed-off-by: Piyush7034 <[email protected]>
No description provided.