Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INJICERT-657] Added DB upgrade scripts for release #146

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Piyush7034
Copy link
Contributor

No description provided.

@Piyush7034 Piyush7034 marked this pull request as ready for review December 9, 2024 08:48
Comment on lines 29 to 33
COMMENT ON COLUMN svg_template.context IS 'VC Context: Context URL list items separated by comma(,)';
COMMENT ON COLUMN svg_template.credential_type IS 'Credential Type: Credential type list items separated by comma(,)';
COMMENT ON COLUMN svg_template.template IS 'Template Content: Velocity Template to generate the VC';
COMMENT ON COLUMN svg_template.cr_dtimes IS 'Date when the template was inserted in table.';
COMMENT ON COLUMN svg_template.upd_dtimes IS 'Date when the template was last updated in table.';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the table name is template_data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed template name

@@ -0,0 +1,33 @@
\c inji_certify

CREATE TABLE svg_template (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename this to rendering template?
the type of image used here is svg, it can be changed as well right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with additional field designating the type of template

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes have to be merged in release branch also and there are templates and repositories associated with this table. Can these changes be taken up for the next release? @vharsh

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're a bit late in designing this template as this change has also gone to released and collab, hence I suggest this to be taken up in next release if possible.

README.md Outdated
1. Create the tables with all the fields that should be returned by the Postgres Data Provider Plugin within the certify postgres database.
- Refer the following query for insertion in DB:
```
CREATE TABLE certify.<table_name> (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we finalizing this design for certify pg plugin?
data present within certify DB?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc refers to the configuration setup for postgres plugin as requested by Likhitha. So it was suggested to add this in the certify docs for reference. This should be updated based on future changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but this is being given as a handover to the QA team and a minimal documentation is required for the same, can we drop this plugin from the scope?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document is now moved to digital-credential-plugins repo under postgres-dataprovider-plugin project as suggested by @vishwa-vyom

Signed-off-by: Piyush7034 <[email protected]>
Signed-off-by: Piyush7034 <[email protected]>
@Piyush7034 Piyush7034 changed the title [INJICERT-499] Added postgres plugin config docs and upgrade scripts [INJICERT-657] Added DB upgrade scripts for release Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants