Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INJICERT-331] Added unit tests for validators and certify issuance service #165

Open
wants to merge 1 commit into
base: release-0.10.x
Choose a base branch
from
Open

[INJICERT-331] Added unit tests for validators and certify issuance service #165

wants to merge 1 commit into from

Conversation

Piyush7034
Copy link
Contributor

No description provided.

vharsh
vharsh approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@vharsh vharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo, we should exclude repositories package from the unit test coverage calculation and avoid writing either business logic inside there unless there's a good reason to do so

certify-service/src/test/java/io/mosip/certify/VCICacheServiceTest.java
public void getVCITransaction_WhenTransactionExists_ShouldReturnTransaction() {
VCIssuanceTransaction transaction = new VCIssuanceTransaction();
transaction.setCNonce("test-cnonce");
when(cacheManager.getCache(VCISSUANCE_CACHE)).thenReturn(cache);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
when(cacheManager.getCache(VCISSUANCE_CACHE)).thenReturn(cache);

nitpick: is this line redundant as this is already added in setup() ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vharsh vharsh vharsh approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Piyush7034 @vharsh