-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOSIP-32782 - Password-protected file is not allowed for upload #718
Conversation
Signed-off-by: GOKULRAJ136 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove handling for non PDF types
- Move document.close() to finally block
Signed-off-by: GOKULRAJ136 <[email protected]>
Removed the handling of non-PDF files and included document.close() in the finally block. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Internal server error is not allowed, it should be proper specific Error Code only
- Try Catch and Finally needs cleanup
- No use of document.isEncrypted
- Check when to send true in all cases in the validation method
Signed-off-by: GOKULRAJ136 <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of returning false on catching IOException, throw the IOException in isPasswordProtectedFile()
Signed-off-by: GOKULRAJ136 <[email protected]>
Threw an IOException instead of catching it. |
…p#718) * MOSIP-32782 - Password-protected file is not allowed for upload Signed-off-by: GOKULRAJ136 <[email protected]> * removed non-pdf files types handling Signed-off-by: GOKULRAJ136 <[email protected]> * error handling for password protection files Signed-off-by: GOKULRAJ136 <[email protected]> * throwing an IOException Signed-off-by: GOKULRAJ136 <[email protected]> --------- Signed-off-by: GOKULRAJ136 <[email protected]>
* MOSIP-33036 - Added upgrade and rollback scripts for release-1.3.x Signed-off-by: GOKULRAJ136 <[email protected]> * fixed apitest-prereg failures Signed-off-by: GOKULRAJ136 <[email protected]> * MOSIP-32782 - Password-protected file is not allowed for upload (#718) * MOSIP-32782 - Password-protected file is not allowed for upload Signed-off-by: GOKULRAJ136 <[email protected]> * removed non-pdf files types handling Signed-off-by: GOKULRAJ136 <[email protected]> * error handling for password protection files Signed-off-by: GOKULRAJ136 <[email protected]> * throwing an IOException Signed-off-by: GOKULRAJ136 <[email protected]> --------- Signed-off-by: GOKULRAJ136 <[email protected]> --------- Signed-off-by: GOKULRAJ136 <[email protected]>
No description provided.