MOSIP-34584 Resolved sonar major and minor bugs

Signed-off-by: MadhuMosip <[email protected]>
mosip · Jul 22, 2024 · dbb1979 · dbb1979
1 parent 04d4a4b
commit dbb1979
Show file tree

Hide file tree

Showing 25 changed files with 47 additions and 65 deletions.
diff --git a/resident-ui/src/app/app.component.ts b/resident-ui/src/app/app.component.ts
@@ -195,9 +195,6 @@ export class AppComponent {
 
   preventBack() {
     window.history.forward();
-    window.onunload = function() {
-      null;
-    };
   }
 
   @HostListener('document:keydown.escape', ['$event']) onKeydownHandler(event: KeyboardEvent) {

diff --git a/resident-ui/src/app/feature/booking/center-selection/center-selection.component.css b/resident-ui/src/app/feature/booking/center-selection/center-selection.component.css
@@ -301,11 +301,9 @@ input[type="radio"] {
 .search-card {
   width: 200px;
   height: 40px;
-  padding: 0;
   box-shadow: 4px black;
   border-radius: 4px !important;
   display: inline-flex;
-  display: inline-flex;
   padding: 7px;
   border: 2px solid #909090;
 }
@@ -423,7 +421,7 @@ input[type="radio"] {
   font-size: var(--fs) !important;
 }
 
-@media screen and ((min-width:601px) and (max-width: 780px)){
+@media screen and (min-width:601px) and (max-width: 780px){
   .map{
     width: 100%;
   }

diff --git a/resident-ui/src/app/feature/booking/center-selection/center-selection.component.html b/resident-ui/src/app/feature/booking/center-selection/center-selection.component.html
@@ -47,8 +47,8 @@
                         placeholder="{{ 'centerSelection.text_search' | translate }}" name="search" class="search-input"
                         [(ngModel)]="searchText" (input)="searchInput()" (blur)="captureValue($event)"
                         (focus)="captureVirtualKeyboard(search, 0)" id="searchLocationBox" #keyboardRef />
-                      <i *ngIf="locationType" style="float: right; color: grey; cursor: pointer;" matSuffix
-                        class="material-icons" (click)="openKeyboard('searchLocationBox')">keyboard</i>
+                      <em *ngIf="locationType" style="float: right; color: grey; cursor: pointer;" matSuffix
+                        class="material-icons" (click)="openKeyboard('searchLocationBox')">keyboard</em>
                     </mat-card>
                   </div>
                   <div class="manual-loc-search-btns" > 

diff --git a/resident-ui/src/app/feature/booking/map/map.component.css b/resident-ui/src/app/feature/booking/map/map.component.css
@@ -4,7 +4,7 @@
     height: 90%;
 }
 
-@media screen and ((min-width:601px) and (max-width: 780px)){
+@media screen and (min-width:601px) and (max-width: 780px){
     .map {
         height: 84%;
     }

diff --git a/resident-ui/src/app/feature/dashboard/dashboard/dashboard.component.css b/resident-ui/src/app/feature/dashboard/dashboard/dashboard.component.css
@@ -130,7 +130,7 @@ div.item-card:hover{
   border-radius: 25px !important;
 }
 
-@media screen and ((min-width:900px) and (max-width:1250px)){
+@media screen and (min-width:900px) and (max-width:1250px){
   .main-div{
     grid-template-columns: 1fr 1fr;
     grid-template-rows: 1fr 1fr;
@@ -141,7 +141,7 @@ div.item-card:hover{
 
 }
 
-@media screen and (max-width:899px){
+@media screen and (min-width:460px) and (max-width:900px){
   .main-div{
     grid-template-columns: 1fr;
     grid-template-rows: 1fr 0.4fr 0.4fr 0.4fr 0.5fr;

diff --git a/resident-ui/src/app/feature/document/document/document.component.html b/resident-ui/src/app/feature/document/document/document.component.html
@@ -13,7 +13,7 @@
     <mat-tab label="{{'dashboard.document' | translate}}"></mat-tab>
   </mat-tab-group>
   <div style="text-align: right;">
-    <button id="downloadAcknowledgementbtn" style="cursor: pointer;" class="download-btn" (click)="downloadSupportingDocument()"><img class="save-icon" src="./assets/images/save.png"/>{{'downloadDocument.downloadbutton' | translate}}</button>
+    <button id="downloadAcknowledgementbtn" style="cursor: pointer;" class="download-btn" (click)="downloadSupportingDocument()"><img alt="" class="save-icon" src="./assets/images/save.png"/>{{'downloadDocument.downloadbutton' | translate}}</button>
   </div>
   <embed *ngIf="pdfSrc" [src]="pdfSrc | sanitizepdf" height="90%" width="100%">
   </div>

diff --git a/resident-ui/src/app/feature/downloaduin/downloaduin/downloaduin.component.css b/resident-ui/src/app/feature/downloaduin/downloaduin/downloaduin.component.css
@@ -18,10 +18,8 @@
     opacity: 1;
     background-color: transparent;
     text-align: left;
-    font: normal normal medium 16px/19px Roboto;
     letter-spacing: 0px;
     color: #909090;
-    opacity: 1;
     display: flex;
     align-items: center;
     justify-content: center;
@@ -114,7 +112,7 @@ label {
     color: #ffffff;
 }
 
-@media screen and ((min-width:530px) and (max-width:755px)){
+@media screen and (min-width:530px) and (max-width:755px){
     .main-container{
         padding: 0 3rem 0 3rem;
     }

diff --git a/resident-ui/src/app/feature/getuin/getuin/getuin.component.css b/resident-ui/src/app/feature/getuin/getuin/getuin.component.css
@@ -23,7 +23,6 @@
 
 .login-heading {
     text-align: center;
-    font: normal normal medium 20px/30px Poppins;
     letter-spacing: 0px;
     color: #000000;
     opacity: 1;
@@ -330,15 +329,15 @@ ul li:last-child hr{
 }
 
 
-@media screen and ((min-width:1000px) and (max-width:1450px)){
+@media screen and (min-width:1000px) and (max-width:1450px){
     ul li:last-child hr{
         width: 88%;
         left: -40%;
         border-radius: 10px;
     }
 }
 
-@media screen and ((min-width:680px) and (max-width:999px)){
+@media screen and (min-width:680px) and (max-width:999px){
     ul li:last-child hr{
         width: 88%;
         left: -34%;

diff --git a/resident-ui/src/app/feature/uinservices/dashboard/dashboard.component.css b/resident-ui/src/app/feature/uinservices/dashboard/dashboard.component.css
@@ -56,13 +56,13 @@ mat-card-title {
   width: 24.5%;
 }
 
-@media screen and ((min-width:1230px) and (max-width:1900px)){
+@media screen and (min-width:1230px) and (max-width:1900px){
   .each-service-card{
     width: 32.5%;
   }
 }
 
-@media screen and ((min-width:900px) and (max-width:1229px)) {
+@media screen and (min-width:900px) and (max-width:1229px) {
   .each-service-card{
     width: 48.5%;
   }

diff --git a/resident-ui/src/app/feature/uinservices/dashboard/dashboard.component.html b/resident-ui/src/app/feature/uinservices/dashboard/dashboard.component.html
@@ -9,7 +9,7 @@ <h2 [style.font-size]="fontSize.heading" class="uin-heading">{{'dashboard.uinser
 		<div *ngIf="menuItems" class="uin-service-card">
 			<div class="each-service-card" *ngFor="let item of menuItems[0].subMenus">
 				<mat-card class="mini-card" (click)="onItemSelected(item.route)" [id]="item.route">
-					<span><img mat-card-xs-image [src]=item.icon /></span>
+					<span><img alt="" mat-card-xs-image [src]=item.icon /></span>
 					<mat-card-title class="uin-services-heading" [style.font-size]="fontSize.headingForUIN">{{item.displayName}}</mat-card-title>
 					<mat-card-subtitle [style.font-size]="fontSize.paragraph"
 						class="services-description">{{item.description}}</mat-card-subtitle>

diff --git a/resident-ui/src/app/feature/uinservices/grievance/grievance.component.html b/resident-ui/src/app/feature/uinservices/grievance/grievance.component.html
@@ -23,7 +23,7 @@
             <label class="label">{{grievanceData.alternateemailidlabel}}</label>
             <div class="input-card">
               <input [style.font-size]="fontSize.lableText" id="alternateEmailID" [attr.maxLength]="emailCharLimit" placeholder="{{grievanceData.alternateEmailPlaceholder}}" type="text" name="alternateEmailId" (blur)="captureValue($event, 'alternateEmailId')" (focus)="captureVirtualKeyboard(search, 0)"  #keyboardRef/>
-              <i matSuffix class="material-icons mat-keyboard-icon" (click)="openKeyboard('alternateEmailID')">keyboard</i>
+              <em matSuffix class="material-icons mat-keyboard-icon" (click)="openKeyboard('alternateEmailID')">keyboard</em>
             </div>
           </div>
           <div class="each-property-card">
@@ -34,7 +34,7 @@
             <label class="label">{{grievanceData.alternatephonenumberlabel}}</label>
               <div class="input-card">
                 <input [style.font-size]="fontSize.lableText" id="alternatePhoneNumber" [attr.maxLength]="phoneCharLimit" placeholder={{grievanceData.alternatePhoneNoPlaceholder}} type="text" name="alternatePhoneNo" (blur)="captureValue($event, 'alternatePhoneNumber')" (focus)="captureVirtualKeyboard(search, 1)"  #keyboardRef/>
-                <i matSuffix class="material-icons mat-keyboard-icon" (click)="openKeyboard('alternatePhoneNumber')">keyboard</i>
+                <em matSuffix class="material-icons mat-keyboard-icon" (click)="openKeyboard('alternatePhoneNumber')">keyboard</em>
               </div>
             </div >
           <div class="each-property-card">
@@ -46,7 +46,7 @@
             <div class="message-input-card">
               <div class="comment-input-sub-card">
                 <textarea [style.font-size]="fontSize.lableText" id="userComment" [attr.maxLength]="totalCommentCount" (input)="countCharacters($event, 'message')" (blur)="countCharacters($event,'message')" (focus)="captureVirtualKeyboard(search, 2)"  #keyboardRef placeholder={{grievanceData.EnterMsgPlaceholder}} rows="4" cols="60" name="message" ></textarea>
-                <i matSuffix class="material-icons mat-keyboard-icon" (click)="openKeyboard('userComment')">keyboard</i>
+                <em matSuffix class="material-icons mat-keyboard-icon" (click)="openKeyboard('userComment')">keyboard</em>
               </div>
                 <span [style.font-size]="fontSize.breadcrumb" class="input-count" >{{grievanceData.TotalCharacters}}: {{totalCommentCount}}</span>
               <span [style.font-size]="fontSize.breadcrumb" class="input-count" >{{grievanceData.remainingCharacters}}: {{remainingChars}}</span>

diff --git a/resident-ui/src/app/feature/uinservices/lockunlockauth/lockunlockauth.component.css b/resident-ui/src/app/feature/uinservices/lockunlockauth/lockunlockauth.component.css
@@ -72,7 +72,6 @@ mat-card-header,
 }
 
 .intro-description {
-  font: normal normal medium 16px/22px Montserrat Medium;
   letter-spacing: 0px;
   color: #505050;
 }
@@ -84,7 +83,7 @@ mat-card-header,
   margin-bottom: 0px;
 }
 
-@media screen and ((min-width:600px) and (max-width:1500px)){
+@media screen and (min-width:600px) and (max-width:1500px){
   .mini-card {
     width: 98%;
     height: 180px;

diff --git a/resident-ui/src/app/feature/uinservices/lockunlockauth/lockunlockauth.component.ts b/resident-ui/src/app/feature/uinservices/lockunlockauth/lockunlockauth.component.ts
@@ -106,6 +106,7 @@ export class LockunlockauthComponent implements OnInit, OnDestroy {
     let authTypes = this.appConfigService.getConfig()["auth.types.allowed"].split(',');
     let authTypesJSON = {};
     let newAuthlist = [];
+    console.log(authTypes)
     this.dataStorageService
     .getAuthlockStatus()
     .subscribe((response) => {
@@ -128,17 +129,16 @@ export class LockunlockauthComponent implements OnInit, OnDestroy {
             authTypesJSON = {};
             authTypesJSON["authType"] = authTypes[i].split('-')[0];
             authTypesJSON["authSubType"] =  authTypes[i].split('-')[1];
-
             if(authTypes[i].split('-')[1]){
-              newAuthlist.find(el => {      
+              newAuthlist.forEach(el => {   
                 if(el.authSubType === authTypes[i].split('-')[1]){
-                  return authTypesJSON["locked"] = el.locked;
+                  authTypesJSON["locked"] = el.locked;
                 }           
               })
             }else{
-              newAuthlist.find(el => {  
+              newAuthlist.forEach(el => {  
                 if(el.authType === authTypes[i]){                  
-                  return authTypesJSON["locked"] = el.locked;
+                  authTypesJSON["locked"] = el.locked;
                 }                    
               })
             }   

diff --git a/resident-ui/src/app/feature/uinservices/personalisedcard/personalisedcard.component.css b/resident-ui/src/app/feature/uinservices/personalisedcard/personalisedcard.component.css
@@ -1,5 +1,4 @@
 .intro-description {
-    font: normal normal medium 16px/22px Montserrat Medium;
     letter-spacing: 0px;
     color: #505050;
 }

diff --git a/resident-ui/src/app/feature/uinservices/personalisedcard/personalisedcard.component.ts b/resident-ui/src/app/feature/uinservices/personalisedcard/personalisedcard.component.ts
@@ -255,13 +255,14 @@ export class PersonalisedcardComponent implements OnInit, OnDestroy {
                 if (eachItem.value === type['value']) {
                   return eachItem['checked'] = !eachItem['checked']
                 } else {
-                  return eachItem['checked'] = eachItem['checked']
+                  return eachItem['checked']
                 }
               })
             }
             return item
           })
 
+
           if (data.attributeName === "fullAddress") {
             let selectedValuesCount = 0;
             if (type["value"] !== 'fullAddress') {

diff --git a/resident-ui/src/app/feature/uinservices/physicalcard/physicalcard.component.css b/resident-ui/src/app/feature/uinservices/physicalcard/physicalcard.component.css
@@ -1,5 +1,4 @@
 .intro-description {
-    font: normal normal medium 16px/22px Montserrat Medium;
     letter-spacing: 0px;
     color: #505050;
   }
diff --git a/resident-ui/src/app/feature/uinservices/revokevid/revokevid.component.css b/resident-ui/src/app/feature/uinservices/revokevid/revokevid.component.css
@@ -9,7 +9,6 @@ ul, li{
   background: #FAF8F8 0% 0% no-repeat padding-box;
   box-shadow: none;
   border: 1px solid silver;
-  background: #FAF8F8 0% 0% no-repeat padding-box;
 }
 .mat-card-header-text{
   display: flex;
@@ -45,7 +44,6 @@ mat-card-subtitle{
 }
 
 .intro-description {
-  font: normal normal medium 16px/22px Montserrat Medium;
   letter-spacing: 0px;
   color: #505050;
 }

diff --git a/resident-ui/src/app/feature/uinservices/revokevid/revokevid.component.html b/resident-ui/src/app/feature/uinservices/revokevid/revokevid.component.html
@@ -32,7 +32,7 @@ <h4 [style.font-size]="fontSize.subHeading" style="color: #000000;">{{langJSON[p
 							  </tr>
 							  <tr>
 							    <td colspan="2" >
-							    	<span [style.font-size]="fontSize.paragraph" class="mat-card-header-text"  *ngIf=list.showvid><span style="width: 11rem;">{{list.vid}}</span>&nbsp;&nbsp;&nbsp;<span style="cursor:pointer;" (click)="displayVid(finalTypeList, policy.vidType, list, false)"><img src="assets\eye_slash.png" style="color: green;width: 18px;"></span></span>
+							    	<span [style.font-size]="fontSize.paragraph" class="mat-card-header-text"  *ngIf=list.showvid><span style="width: 11rem;">{{list.vid}}</span>&nbsp;&nbsp;&nbsp;<span style="cursor:pointer;" (click)="displayVid(finalTypeList, policy.vidType, list, false)"><img alt="" src="assets\eye_slash.png" style="color: green;width: 18px;"></span></span>
 							    	<span [style.font-size]="fontSize.paragraph" class="mat-card-header-text" *ngIf=!list.showvid><span style="width: 11rem;">{{list.maskedVid}}</span>&nbsp;&nbsp;&nbsp;<mat-icon style="color: green;font-size: 18px;cursor:pointer;" (click)="displayVid(finalTypeList, policy.vidType, list, true)">remove_red_eye</mat-icon></span>
 							    </td>
 							  </tr>
@@ -61,7 +61,7 @@ <h4 [style.font-size]="fontSize.subHeading" style="color: #000000;">{{langJSON[p
 							    	<span [style.font-size]="fontSize.paragraph" *ngIf="!list.transactionsLeftCount">NA</span>							    	
 							    </td>
 							    <td style="width:50%;float: right;">
-							    	<span (click)="downloadVIDBtn(list.vid,policy.vidType)" style="color: green;font-size: 24px;cursor:pointer;"><img id="download{{i}}" src="assets\download.png"></span>&nbsp;&nbsp;&nbsp;
+							    	<span (click)="downloadVIDBtn(list.vid,policy.vidType)" style="color: green;font-size: 24px;cursor:pointer;"><img alt="" id="download{{i}}" src="assets\download.png"></span>&nbsp;&nbsp;&nbsp;
 							    	<mat-icon id="delete{{i}}" style="color: #DB4F4F;font-size: 24px;cursor:pointer;" (click)="revokeVIDBtn(list.vid,policy.vidType)">delete</mat-icon>
 							    </td>
 							  </tr>

diff --git a/resident-ui/src/app/feature/uinservices/revokevid/revokevid.component.ts b/resident-ui/src/app/feature/uinservices/revokevid/revokevid.component.ts
@@ -296,7 +296,7 @@ export class RevokevidComponent implements OnInit, OnDestroy {
   revokeVIDBtn(vidValue: any,vidType:any){
     this.showDeleteMessage(vidType)
     this.newVidValue = vidValue
-    this.newVidType - vidType
+    this.newVidType = vidType
   }
 
   revokeVID(vidValue: any) {

diff --git a/resident-ui/src/app/feature/uinservices/sharewithpartner/sharewithpartner.component.css b/resident-ui/src/app/feature/uinservices/sharewithpartner/sharewithpartner.component.css
@@ -34,7 +34,6 @@
 
 .success-msg-description {
   text-align: left;
-  font: normal normal medium 14px/22px Poppins;
   letter-spacing: 0px;
   color: #505050;
   margin-left: 1.5rem;
@@ -43,7 +42,6 @@
 }
 
 .success-msg-text {
-  font: normal normal medium 20px/20px Poppins;
   letter-spacing: 0px;
   color: #03A64A;
   font-size: 21px;
@@ -56,7 +54,6 @@
 
 .transaction-title {
   text-align: left;
-  font: normal normal medium 22px/24px Montserrat SemiBold;
   letter-spacing: 0px;
   color: #505050;
   margin-bottom: 0px;
@@ -84,7 +81,6 @@
 }
 
 .intro-description {
-  font: normal normal medium 16px/22px Montserrat Medium;
   letter-spacing: 0px;
   color: #505050;
 }

diff --git a/resident-ui/src/app/feature/uinservices/sharewithpartner/sharewithpartner.component.html b/resident-ui/src/app/feature/uinservices/sharewithpartner/sharewithpartner.component.html
@@ -117,7 +117,7 @@ <h3 [style.font-size]="fontSize.headingForUIN" style="color: #050505;">{{'sharew
 											(input)="getpurpose($event)"
 											(blur)="getpurpose($event)"
                                             (focus)="captureVirtualKeyboard(search, 0)" #keyboardRef></textarea>
-											<i style="float: right; color: grey; cursor: pointer;" matSuffix class="material-icons" (click)="openKeyboard()">keyboard</i>
+											<em style="float: right; color: grey; cursor: pointer;" matSuffix class="material-icons" (click)="openKeyboard()">keyboard</em>
 										</span>
 											<span [style.fontSize]="fontSize.breadcrumb"
 											style="color:red; display: block;">{{'sharewithpartner.TotalCharacters'

diff --git a/resident-ui/src/app/feature/uinservices/sharewithpartner/sharewithpartner.component.ts b/resident-ui/src/app/feature/uinservices/sharewithpartner/sharewithpartner.component.ts
@@ -318,7 +318,7 @@ export class SharewithpartnerComponent implements OnInit, OnDestroy {
                 if (item.value === type['value']) {
                   return item['checked'] = !item['checked']
                 } else {
-                  return item['checked'] = item['checked']
+                  return item['checked']
                 }
               })
             }