Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release 19-04-2023] Android stability improvements & developer compatibility enhancements #58

Merged
merged 31 commits into from
Apr 19, 2023
Merged

[Release 19-04-2023] Android stability improvements & developer compatibility enhancements #58

merged 31 commits into from
Apr 19, 2023

Conversation

vharsh
Copy link
Member

@vharsh vharsh commented Apr 19, 2023 •
edited
Loading

krishnakumar4a4 and others added 22 commits March 28, 2023 16:57
@krishnakumar4a4
Merge pull request #50 from mosip/release/0.3.x
15ae123 
Release/0.3.x
@krishnakumar4a4
docs(#413): update ble capture steps for multiple android devices
5917ad1
@krishnakumar4a4
docs(#413): add tuvali spec implementation document with technical fl…
89f2dff 
…ow diagram
@shreethaanu
feat(#583): [Shree] [iOS] added exception handler for wallet
696361b
@shreethaanu
feat(#583): [Shree] [iOS] added exception handler for wallet
dbe7301
@shreethaanu
feat(#583): [Shree] [iOS] added exception handler for verifier and re…
68b7a26 
…moved unused code
@shreethaanu
feat(#583): [Shree] [iOS] addressed PR Comments
3d9521e
@tilak-puli
feat(#702): run Openid4vpBleModule public function under try and catch
f3dcb36
@tilak-puli
feat(#702): add root level exception handler at react native module
1abfc0e
@shreethaanu
feat(#583): [Shree] [iOS] addressed PR Comments
1e42858
@tilak-puli
feat(#702): remove root level exception handler at react native module
cc864ca
@shreethaanu
feat(#583): [Shree] [iOS] changed info logs to error logs
3f0b407
@tilak-puli
feat(#702): fix stop ble -> error handling cyclic issue
17635b3
@shreethaanu
feat(#583): [Shree] [iOS] fixed pr comments
fff52f2
@krishnakumar4a4
refactor(#583): error handling and rename identifiers
dbb7d74 
- Update error handling similar to android impl
- Rename enums to reflect programming language convention
@vharsh
chore: [iOS] fix compilation errors in Errorhandler
f5a5777
@vharsh
chore: fix compilation errors
f7aea5b
@vharsh
chore: [iOS] avoid force unwrap of identifier
a8c9164
@krishnakumar4a4
Merge pull request #43 from ravikp/add-exception-handling-to-android-…
e04c307 
…missing-files

fix(mosip/inji-wallet#702): Add exception handling to android missing files
@tilak-puli
feat(#702): catch throwable instead of Exception
d11c883
@KiruthikaJeyashankar
refactor(mosip#696): [Kiruthika] Remove example folder and its relate…
2821e25 
…d scripts (#50)

Modified to make it compatible with windows
@tilak-puli
feat(#702): catch throwable instead of Exception
ade32a1
@vharsh vharsh requested a review from vijay151096 April 19, 2023 08:39
vijay151096
vijay151096 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@vijay151096 vijay151096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

vharsh and others added 2 commits April 19, 2023 14:22
@ravikp ravikp requested a review from vijay151096 April 19, 2023 09:11
vijay151096
vijay151096 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@vijay151096 vijay151096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vharsh vharsh requested a review from krishnakumar4a4 April 19, 2023 10:26
krishnakumar4a4
krishnakumar4a4 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@krishnakumar4a4 krishnakumar4a4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@krishnakumar4a4 krishnakumar4a4 merged commit cf22b78 into mosip:release-0.3.x Apr 19, 2023
krishnakumar4a4 pushed a commit that referenced this pull request Jun 12, 2023
@vharsh
Merge pull request #58 from tw-mosip/update-API-def
e3892d9 
Update Tuvali API definitions (Move away from Google Nearby API definitions)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijay151096 vijay151096 vijay151096 approved these changes

@krishnakumar4a4 krishnakumar4a4 krishnakumar4a4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vharsh @krishnakumar4a4 @vijay151096 @shreethaanu @tilak-puli @KiruthikaJeyashankar @Alka1703