Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo/app.py): Drop nested button. #24

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Nov 28, 2024

Background in https://discuss.streamlit.io/t/how-to-do-nested-button-and-print-both-button-outputs/33741

@Kostis-S-Z it turns out that having 2 nested buttons requires some more elaborated changes to handle the session state. This is a quick fix that just makes the demo work.

There is a different problem, though, which is that parse_script_to_waveform doesn't work with the current output format. In the current test, you are setting the input differently and that is why the test pass. You are missing some quotes around the strings like:

"Speaker 1": "Yes, and by working together, we can create a more accessible and inclusive AI ecosystem that benefits everyone."

@daavoo daavoo self-assigned this Nov 28, 2024
@daavoo daavoo requested a review from Kostis-S-Z November 28, 2024 13:42
Copy link
Contributor

@Kostis-S-Z Kostis-S-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daavoo daavoo merged commit 9ee2c91 into 6-audio-generation-component Nov 28, 2024
1 check passed
@daavoo daavoo deleted the audio-demo branch November 28, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants