Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try outetts #27

Closed
wants to merge 13 commits into from
Closed

Try outetts #27

wants to merge 13 commits into from

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Nov 29, 2024

What's changing

  • Replace parler_tts with outetts.
  • Cleanup code not used in demo/app.py

How to test it

Inside codespaces, run:

bash .github/setup.sh
python -m streamlit run demo/app.py

Additional notes for reviewers

@daavoo daavoo changed the base branch from main to audo-demo-chunks November 29, 2024 16:03
@Kostis-S-Z
Copy link
Contributor

I know this is still a draft, but do you think we should completely remove the support for parler or should we keep it as an optional, additional dependency for people that might want to experiment with another model and dont mind downloading a huge package? To clarify, I agree parler shouldnt be in the main dependencies of the project, but have it as an option.

@daavoo
Copy link
Contributor Author

daavoo commented Dec 3, 2024

I know this is still a draft, but do you think we should completely remove the support for parler or should we keep it as an optional, additional dependency for people that might want to experiment with another model and dont mind downloading a huge package? To clarify, I agree parler shouldnt be in the main dependencies of the project, but have it as an option.

We can keep both set of functions supported in the API but chose to use a specific one in the demo.
I did the changes here the fastest way, which was to completely overwrite it so we could test the draft in the demo.

Base automatically changed from audo-demo-chunks to 6-audio-generation-component December 3, 2024 11:09
@daavoo
Copy link
Contributor Author

daavoo commented Dec 3, 2024

After our discussions, I am closing this.
It is probably smarter to use one of the frameworks @Kostis-S-Z researched instead of having more than 1 model-specific functions

@daavoo daavoo closed this Dec 3, 2024
@daavoo daavoo deleted the try-outetts branch December 3, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants