Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate text area bug #45

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix duplicate text area bug #45

merged 1 commit into from
Dec 9, 2024

Conversation

Kostis-S-Z
Copy link
Contributor

@Kostis-S-Z Kostis-S-Z commented Dec 6, 2024

What's changing

Make text areas distinct to prevent streamlit from crashing when the content is identical.
The low-hanging fruit solution was to simply change the "pre-text" of the areas to be different so from:
Total Length: for both to Number of characters before cleaning: and Number of characters after cleaning:

For more info check #43 .

Closes #43

How to test it

Steps to test the changes:

  1. Run demo app
  2. Create empty file file.md and inside write This is an example
  3. Upload file to app
  4. No crash 🎉

Additional notes for reviewers

~

I already...

  • Tested the changes in a working environment to ensure they work as expected
  • Added some tests for any new functionality
  • Updated the documentation (both comments in code and under /docs)

Sorry, something went wrong.

@Kostis-S-Z Kostis-S-Z linked an issue Dec 6, 2024 that may be closed by this pull request
1 task
@Kostis-S-Z Kostis-S-Z requested a review from daavoo December 6, 2024 17:28
@Kostis-S-Z Kostis-S-Z self-assigned this Dec 6, 2024
Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@daavoo daavoo merged commit d1a899b into main Dec 9, 2024
3 checks passed
@daavoo daavoo deleted the 43-bug-duplicate-widget-id branch December 9, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: If raw text = cleaned text, app crashes
2 participants