-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix codespace issue #46
Conversation
@Kostis-S-Z - i just tried to test this. I may be doing something wrong, but on this branch, I created default codespace and it did the 8GB version, not the 16GB version. Also, i tried just running |
Thanks for testing @stefanfrench ! I am aware that its not working on this branch (thats why I also wrote in the notes of the PR "Not sure how we can test this before merging to main :/"). This is because when you start the codespaces it only looks at I found the fix here. We basically need to enable pre-build codespaces, but when I tried to set it up I got this! I guess we need to look into this and see what the cost would be. |
I think is ok to merge and test from |
It looks like these changes had no effect, I tested the default creation from main after merging this PR |
What's changing
Currently the
.devcontainer.json
is ignored because its under the.github
directory. It needs to be either inroot
or.devcontainer/
according to the docs.This meant that the default configuration of codespaces for a machine with 16GB RAM was ignored, and instead was using the 8GB RAM machine which is not sufficient to properly run the demo app in codespaces. Thanks @ameckes1229 for the discovery!
Also the pre-installation step used in the
.devcontainer.json
was deprecated and now its updated to use the.github/setup.sh
script.How to test it
Steps to test the changes:
+
)Code
in the repo ->...
in the active codespace ->Change machine type
-> Verify that the machine selected is the 16GB oneAdditional notes for reviewers
Not sure how we can test this before merging to main :/Edit: The only way to test this (to my understanding) is by using pre-build codespaces, but we need to discuss how or if we can set this up on org level. About testing codespaces configuration changes here
I already...
/docs
)