This repository has been archived by the owner on Sep 24, 2024. It is now read-only.
New huggingface eval for the summarization use case with rouge, meteor, and bertscore #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veekaybee
reviewed
Jun 12, 2024
veekaybee
reviewed
Jun 12, 2024
veekaybee
reviewed
Jun 12, 2024
veekaybee
reviewed
Jun 12, 2024
veekaybee
reviewed
Jun 12, 2024
veekaybee
reviewed
Jun 12, 2024
veekaybee
reviewed
Jun 12, 2024
veekaybee
reviewed
Jun 12, 2024
binaryaaron
reviewed
Jun 12, 2024
There was a problem hiding this comment.
mostly responding / adding on to @veekaybee's review; will look more later. thanks!
veekaybee
reviewed
Jun 12, 2024
veekaybee
reviewed
Jun 12, 2024
veekaybee
approved these changes
Jun 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing
Added a new
evaluate huggingfaceentrypoint which supports evaluation of local and remote models (seq2seq, causal, openai, vllm, llamafile) and loading datasets / saving results on s3.How to test it
Related Jira Ticket
https://mzai.atlassian.net/browse/MZPLATFORM-78
Additional notes for reviewers
I know we discussed messaging to mzai-platform's backend directly from lm-buddy jobs.
I am 100% in favor of it, I just wanted to keep this PR independent from messaging and I will create a new one to be tested together with the updated mzai-platform code.