This repository has been archived by the owner on Sep 24, 2024. It is now read-only.
Added model_max_length as a tok parameter #113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 4.40.0, transformers does not get model_max_tokens from the model's family dict but explicitly looks for this parameter in
tokenizer_config.json
. Not all models provide this, so one possibility is to explicitly allow users to provide this parameter in the config. This PR implements exactly this.Tested with facebook/bart-large-cnn + pytest unit/integration tests.