You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 24, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I updated pyproject.toml to use more recent libs. The main reason was transformers so we could run more recent models but I ran a general update using pip-review to get latest versions. These are the steps I followed:
used pip-review to update all libs
check there were no inconsistencies
test lm-buddy with the new set of libs
updated pyproject.toml by picking the updated versions from the output of pip freeze
re-installed everything in a new env and made sure there were no inconsistencies
tested lm-buddy again
How to test it
The tests I ran were unit/integration tests + manually running lm-buddy for summarization eval (currently our main job).
Interestingly, tests/integration/test_lm_harness.py::test_lm_harness_job passes when I test locally
ruff on github returns an error which I do not get at precommit nor when I run it manually. Is there anything else I should change in the repo to make sure the two are aligned? (nothing major, I'd just like to prevent errors happening here if I can)
I still wonder what is different between my local tests and github's as they all pass locally (in particular the lm-harness one which breaks online):
I added some minor changes and changed the test task to one that doesn't require HF remote code. there's something odd with how those args are being passed; i opened #115 to revisit this after the demo.
I added some minor changes and changed the test task to one that doesn't require HF remote code. there's something odd with how those args are being passed; i opened #115 to revisit this after the demo.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing
I updated pyproject.toml to use more recent libs. The main reason was transformers so we could run more recent models but I ran a general update using
pip-review
to get latest versions. These are the steps I followed:pyproject.toml
by picking the updated versions from the output ofpip freeze
How to test it
The tests I ran were unit/integration tests + manually running lm-buddy for summarization eval (currently our main job).
Interestingly,
tests/integration/test_lm_harness.py::test_lm_harness_job
passes when I test locally