This repository has been archived by the owner on Sep 24, 2024. It is now read-only.
Update Ray job submission example in README #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will merge this on top of this PR merge, needed to pin a few dependencies #119 |
|
Related version update: #120 |
|
@dpoulopoulos Since we made a change in requirements here to satisfy failing tests, if you could also add a version bump in your PR in |
Commit 0975fb2 changes the CLI groups `finetune` and `evaluate`, but the Ray job submission example in the README file still uses the deprecated `run` command. Update the example to match the new API. Signed-off-by: Dimitris Poulopoulos <[email protected]>
dpoulopoulos
force-pushed
the
update-readme-ray-example
branch
from
713a498 to
4e53b16
Compare
Add a version bump in `pyproject.toml` to satisfy the semver check. Signed-off-by: Dimitris Poulopoulos <[email protected]>
|
@veekaybee I added a semver bump commit on top and rebased the whole branch on top of |
|
Perfect, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 0975fb2 changes the CLI groups
finetuneandevaluate, but the Ray job submission example in the README file still uses the deprecatedruncommand.What's changing
Update the example to match the new API.
How to test it
Run the example script on a Ray cluster.