RD2024-45: Setup test structure for ITs #13
Conversation
| from flamingo.jobs.simple import SimpleJobConfig | ||
|
|
||
|
|
||
| @ray.remote |
There was a problem hiding this comment.
I'm Ray-ifying this entrypoint so we actually have something to test in the ITs
| @@ -0,0 +1,60 @@ | |||
| """ | |||
| Flamingo integration test suite. | |||
There was a problem hiding this comment.
I may have missed this in earlier PRs but do we have some docs around testing?
There was a problem hiding this comment.
We don't really have docs yet. We should add to the contributing guide eventually
| print(f"The magic number is {config.magic_number}") | ||
| """A simple entrypoint to demonstrate the Ray interface.""" | ||
| # Connect to the Ray cluster (if not already running) | ||
| ray.init(ignore_reinit_error=True) |
There was a problem hiding this comment.
@aittalam this is an example of launching a ray cluster if not already existing. I am able to run this on my local machine without explicitly launching a Ray cluster.
flamingo run simple --config examples/configs/simple_config.yaml
|
@binaryaaron as Vicki approved, and we discussed this a bit via Slack, I'm going to roll w/ this initial PR. We can iterate and add more tests as we progress. |
🚢 |
Sets up the basic pattern for unit/ITs in the repo.
unitandintegrationfolders undertests, so we easily run each suite independentlyconftest.pyto integration that includes setup of a basic Ray cluster for testing. I leave docstring comments on things we probably want to iterate on here in the futuresimplejob entrypoint.I have not yet gone through extensively testing the production finetuning/eval jobs. I want to do this in a separate PR to avoid it being overwhelming.