-
Notifications
You must be signed in to change notification settings - Fork 3
Added v0 of prometheus lm-buddy entrypoint #75
Conversation
Signed-off-by: Davide Eynard <[email protected]>
Signed-off-by: Davide Eynard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall with the format of the new job! A handful of comments, some bigger than others. Happy to discuss more or chat offline if anything didn't make sense.
…ean's comment Co-authored-by: Sean Friedowitz <[email protected]> Signed-off-by: Davide Eynard <[email protected]>
Many thanks for your comments! I will go through them (marked all of the actionable ones with a 👍) and also fix the linting issues before asking for approval 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve this for now as most comments have been addressed. I left a few other smaller nit comments you may want to tackle as well in this PR.
In a followup, I think it would be good to take another iteration at the following:
- Refining how we store generated results to disk, and the format of the W&B artifacts. E.g., do we log cumulative metrics from the eval as a Run Table for easy visualization, in addition to the file artifact?
- Adding test coverage, both for ser/de issues on the new configs, and for the job entrypoint as a whole.
Signed-off-by: Davide Eynard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Here's the first version of the lm-buddy prometheus entrypoint!
I tried to keep the script relatively close to the original evaluation script, as I'd like to use it as a use case for a "conversion" of some existing tool (a tutorial is being written...)
I feel it still needs some massaging as I am not 100% sure of the implementation choices I took (format of configs, using one method or another to get artifacts, etc). Happy to receive some early feedback and iterate on it soon!