Skip to content
This repository has been archived by the owner on Sep 24, 2024. It is now read-only.

Davide/tutorial #97

Merged
merged 8 commits into from
Apr 23, 2024
Merged

Davide/tutorial #97

merged 8 commits into from
Apr 23, 2024

Conversation

aittalam
Copy link
Member

Fixed missing lib and updated docs + examples for a prometheus tutorial.

sfriedowitz
sfriedowitz reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@sfriedowitz sfriedowitz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple quick comments but the new stuff looks fine. Also a version bump

veekaybee
veekaybee approved these changes Apr 23, 2024
View reviewed changes
docs/source/evaluation_concepts.md Outdated Show resolved Hide resolved
@aittalam
Copy link
Member Author

Just a heads up that I got a argument of type 'PosixPath' is not iterable error from a test in tests/unit/test_preprocessing.py. Fixed it by casting on str but was surprised to see that happening.

@aittalam aittalam merged commit 1f8ed27 into main Apr 23, 2024
4 checks passed
@aittalam aittalam deleted the davide/tutorial branch April 23, 2024 18:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfriedowitz sfriedowitz sfriedowitz left review comments

@veekaybee veekaybee veekaybee approved these changes

@imtihan imtihan Awaiting requested review from imtihan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aittalam @veekaybee @sfriedowitz