Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(pulse): This mirrors the pulse endpoint used by the existing … #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feature(pulse): This mirrors the pulse endpoint used by the existing … #7

wants to merge 2 commits into from

Conversation

bkochendorfer
Copy link
Member

…container

@bkochendorfer bkochendorfer requested a review from smarnach June 17, 2022 17:59
@bkochendorfer
Copy link
Member Author

This could also just use the same method as the Dockerflow __lbheartbeat__ but wasn't sure if we were going to try to use the Dockerflow stuff, it isn't something we are using on the Pocket side.

@bkochendorfer bkochendorfer requested a review from a team June 17, 2022 20:15
rvaralda
rvaralda reviewed Jul 5, 2022
View reviewed changes
src/endpoints/pulse.rs Outdated
use serde_derive::Serialize;

#[derive(Serialize)]
struct PuleResponse {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/PuleResponse/PulseResponse/

src/endpoints/pulse.rs Outdated
}

pub async fn pulse() -> Result<HttpResponse, ProxyError> {
let response = PuleResponse {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/PuleResponse/PulseResponse/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvaralda rvaralda rvaralda left review comments

@smarnach smarnach Awaiting requested review from smarnach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkochendorfer @rvaralda