Only apply VPIO properties while running #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An Apple bug breaks, at least, the bypass property if it is set prior to starting the VPIO unit. Broken here means that the property can be set to any value later while running, without having an effect. The VPIO defaults is bypass OFF and AGC ON. Starting like that and then turning on bypass as requested is not going to cause an unexpected glitch. We reset the VPIO to defaults before stopping so that on reuse it doesn't risk causing a glitch either.
padenot
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Apple bug breaks, at least, the bypass property if it is set prior to starting the VPIO unit. Broken here means that the property can be set to any value later while running, without having an effect.
The VPIO defaults is bypass OFF and AGC ON. Starting like that and then turning on bypass as requested is not going to cause an unexpected glitch. We reset the VPIO to defaults before stopping so that on reuse it doesn't risk causing a glitch either.