Skip processing of output render callbacks with 0 frames #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pehrsons
force-pushed
the
no-empty-data-callback
branch
from
52299fe to
908814c
Compare
The current HOST_TIME_TO_NS_RATIO implemented with lazy_static is causing what appears to be false-positive TSAN errors. OnceLock and LazyLock exhibit similar errors under TSAN. It seemed easier to rewrite host_time_to_ns_ratio to be a init-once context member, rather than making the unstable `no_sanitize` attribute work. Being unstable it also needed to be included conditionally only when compiled with the nightly compiler. And trying the rustversion crate for this resulted in compilation failure due to TSAN reporting it doesn't work...
Pehrsons
force-pushed
the
no-empty-data-callback
branch
from
908814c to
8400cfa
Compare
padenot
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speculative fix for
https://bugzilla.mozilla.org/show_bug.cgi?id=1902989.