Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using map_err over inspect_err #231

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Using map_err over inspect_err #231

merged 1 commit into from
Aug 6, 2024

Conversation

ChunMinChang
Copy link
Member

This patch fixes clippy::manual-inspect error. See [1] for details.

[1] https://rust-lang.github.io/rust-clippy/master/index.html#/manual_inspect

This patch fixes clippy::manual-inspect error. See [1] for details.

[1] https://rust-lang.github.io/rust-clippy/master/index.html#/manual_inspect
Copy link
Contributor

@Pehrsons Pehrsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe log the es instead of remove them? Seems useful.

LGTM either way

@ChunMinChang
Copy link
Member Author

Maybe log the es instead of remove them? Seems useful.

LGTM either way

Thanks for the review!

Those errors are lib libcubeb's errors like InvalidFormat or InvalidParameter, not providing helpful information for debugging, so I didn't log them. I'll leave them as they are for now.

@ChunMinChang ChunMinChang merged commit 45a6ff1 into trailblazer Aug 6, 2024
8 checks passed
@ChunMinChang ChunMinChang deleted the fix-clippy-err branch August 6, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants