Delay reinitialization when the stream is paused while the change happens #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padenot
force-pushed
the
reinit-while-aused
branch
2 times, most recently
from
6c22759 to
7deb2a2
Compare
Pehrsons
requested changes
Aug 9, 2024
There was a problem hiding this comment.
You removed the error early-exit guard on the result from the run_sync block in start. That needs to be fixed.
I think the test should also check that the audio unit has started, once start with the delayed reinit returns success. Either by checking an internal state, or that the state callback fired a started event.
Consider the rest nits.
padenot
force-pushed
the
reinit-while-aused
branch
from
7deb2a2 to
88b1802
Compare
Pehrsons
approved these changes
Aug 9, 2024
…einitialize the stream next time it is started
…re the ones we expect before and after switching
padenot
force-pushed
the
reinit-while-aused
branch
from
88b1802 to
f04a50e
Compare
Pehrsons
approved these changes
Aug 9, 2024
…while paused, or when starting fails
padenot
force-pushed
the
reinit-while-aused
branch
from
f04a50e to
e8f19e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1907780