Mark some spammy logs as verbose. #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a very brief usage of cubeb-coreaudio-rs (<1 minute), I observed substantial log output from the following lines: 880 mod.rs:1767 880 mod.rs:1848 1479 mod.rs:3274 1618 mod.rs:1758 2498 mod.rs:1715 3236 mod.rs:1727 8870 device_property.rs:268 8870 device_property.rs:282 9708 mod.rs:2014 Of these, only one (mod.rs:1848) is an error. The others are informational, so make them verbose logs.
|
cc @padenot @kinetiknz for review :) |
|
This is intentional. Those logging statement are at the level "debug", and those are debugging information. Verbose is when outputting logging messages once per callback. Generally, when logging in "debug" mode, all the information that let the cubeb developer understand how a stream was created, including the various workarounds on all platforms, are logged. Verbose is for things that are really verbose, happen during capture/rendering. Those aren't strict rules. |
|
Got it, okay. It might be nice to have a distinction between "info" level logs and "warning/error" level logs, but that sounds like it would be a substantially larger project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a very brief usage of cubeb-coreaudio-rs, I observed substantial log output from the following lines: (format is "<count> <file>:<line>")
880 mod.rs:1767
880 mod.rs:1848
1479 mod.rs:3274
1618 mod.rs:1758
2498 mod.rs:1715
3236 mod.rs:1727
8870 device_property.rs:268
8870 device_property.rs:282
9708 mod.rs:2014
Of these, only one (mod.rs:1848) is an error. The others are informational, so make them verbose logs.