Run the tests in the subcrate #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format check should always be run, in main crate and sub crate, not only in Travis CI server only. The format checks and lints(clippy) checks should be moved from .travis.yml to run_tests.sh.
padenot
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test in the sub-crate, coreaudio-sys-utils, aren't run in both local device and Travis CI server. Those tests in the coreaudio-sys-utils should also be run with the sanitizers. It will be easier to identify the problem (if any) is in the underlying system API implemented in the sub-crate, or it's in the main crate, by running the tests in the sub crate.
Running those tests is helpful to diagnose the problem, or narrow down the scope of the problem at least. For example, there are memory leaks found by running MemorySanitier with the tests in the coreaudio-sys-utils. It indicates the memory is leaking when calling the underlying APIs. It's helpful to address the leak issue found in #45.
On the other hand, the format check and the lints/clippy check should always be run, instead of running in Travis CI server only. It makes sure every commit follows the Rust coding style properly.