Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Move BaselinePingTests logically into the right folder #2966

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

badboy
Copy link
Member

@badboy badboy commented Oct 1, 2024

On-disk file organization doesn't matter for Xcode whatsoever. Turns out that BaselinePingTest was dropped into the wrong folder in Xcode over 2 years ago. Now moved into the same folder in the Xcode project as it is on disk.

On-disk file organization doesn't matter for Xcode whatsoever.
Turns out that BaselinePingTest was dropped into the wrong folder in
Xcode over 2 years ago. Now moved into the same folder in the Xcode
project as it is on disk.
@badboy badboy requested a review from a team as a code owner October 1, 2024 11:50
@badboy badboy requested review from rosahbruno and removed request for a team October 1, 2024 11:50
@badboy badboy enabled auto-merge (rebase) October 1, 2024 11:53
@badboy badboy requested a review from travis79 October 1, 2024 11:53
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.54%. Comparing base (adfdc11) to head (6c76bf6).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2966   +/-   ##
=======================================
  Coverage   29.54%   29.54%           
=======================================
  Files           1        1           
  Lines          44       44           
=======================================
  Hits           13       13           
  Misses         31       31           
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badboy badboy merged commit 4921703 into main Oct 1, 2024
34 checks passed
@badboy badboy deleted the ios-move-tests branch October 1, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants