Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same test ping names consistently throughout all tests #3001

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

badboy
Copy link
Member

@badboy badboy commented Nov 15, 2024

This is in preparation of the further changes coming to how we handle pings.

This is in preparation of the further changes coming to how we handle
pings.
@badboy badboy requested a review from a team as a code owner November 15, 2024 09:19
@badboy badboy requested review from rosahbruno and removed request for a team November 15, 2024 09:19
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.54%. Comparing base (fa7aff2) to head (00ce5bd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3001   +/-   ##
=======================================
  Coverage   29.54%   29.54%           
=======================================
  Files           1        1           
  Lines          44       44           
=======================================
  Hits           13       13           
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@badboy badboy requested review from travis79 and removed request for rosahbruno November 15, 2024 13:55
@badboy badboy merged commit 2b80301 into main Nov 19, 2024
34 checks passed
@badboy badboy deleted the concistent-ping-names branch November 19, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant