Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci skip-rerun] fix: change desktop default DAU metric to v2 #690

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[ci skip-rerun] fix: change desktop default DAU metric to v2 #690

merged 1 commit into from
Nov 19, 2024

Conversation

mikewilli
Copy link
Collaborator

  • change the default DAU metric for experiments to the non-deprecated _v2 version
  • also matches with mobile, which is helpful for changing the guardrails in Experimenter
  • skip rerunning jetstream for all desktop experiments

@github-actions GitHub Actions
Copy link

⚠️ Changing default metrics will cause all experiments that are currently live to get rerun after this change has been merged. This may come with a substantial cost. To skip reruns, add [ci skip-rerun] to the PR message.

@github-actions GitHub Actions
Copy link

⚠️ Changing default metrics will cause all experiments that are currently live to get rerun after this change has been merged. This may come with a substantial cost. To skip reruns, add [ci skip-rerun] to the PR message.

bochocki
bochocki approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@bochocki bochocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mikewilli mikewilli added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit 5743720 Nov 19, 2024
7 checks passed
@mikewilli mikewilli deleted the fix-desktop-defaults branch November 19, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@bochocki bochocki bochocki approved these changes

@danielkberry danielkberry Awaiting requested review from danielkberry danielkberry is a code owner

@scholtzan scholtzan Awaiting requested review from scholtzan scholtzan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikewilli @bochocki