This repository has been archived by the owner on Jul 30, 2019. It is now read-only.
Update HTTP to HTTPS & link fix #1113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 22, 2018 20:55
Change links to HTTPS.
Problem: t3n link was gone, replaced it with the archived link. Change links to HTTPS. Exception: www.alphr.com, website uses self-signed certificate.
Change links to HTTPS.
Change links to HTTPS.
Change links to HTTPS.
Change links to HTTPS.
ghost
mentioned this pull request
mmmavis
suggested changes
Oct 1, 2018
There was a problem hiding this comment.
Hey @missuniverse thanks for filing this PR! I just left some inline comments.
| @@ -54,7 +54,7 @@ const PAST_COVERAGE = [ | |||
| { | |||
| media: `t3n`, | |||
| title: `Wie steht es um die Gesundheit des Internets? Auf Spurensuche beim Mozilla-Festival`, | |||
| link: `http://t3n.de/news/mozilla-festival-internet-gesundheit-761360/3/`, | |||
| link: `https://web.archive.org/web/20170112212535/http://t3n.de/news/mozilla-festival-internet-gesundheit-761360/3/`, | |||
There was a problem hiding this comment.
Hey @KevZawacki the link for tn3 on https://mozillafestival.org/media is not available anymore. Is it okay if we fix the link to https://web.archive.org/web/20170112212535/http://t3n.de/news/mozilla-festival-internet-gesundheit-761360/3/ or you have other suggestion?
There was a problem hiding this comment.
pinging @KevZawacki again in case you missed this
Removed HTTPS issue with one of the links.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change links to HTTPS when supported.
Found an invalid link and replaced it with the archived version.
Some links weren't changed because the websites didn't support it or had invalid SSL certificates.