Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for consistency of various Python versions #406

Open
grahamalama opened this issue Apr 6, 2023 · 1 comment
Open

Check for consistency of various Python versions #406

grahamalama opened this issue Apr 6, 2023 · 1 comment

Comments

@grahamalama
Copy link
Contributor

We have a few Python versions defined throughout the repo:

> rg "3\.11" -g '!*.rst' -g '!.git/*' --hidden

.readthedocs.yaml
6:    python: "3.11"

.circleci/config.yml
236:      - image: cimg/python:3.11.2
252:      - image: cimg/python:3.11.2
263:      - image: cimg/python:3.11.2

poetry.lock
3378:python-versions = "^3.11"

pyproject.toml
50:python = "^3.11"

RemoteSettings.Dockerfile
1:FROM python:3.11.3 as compile
30:FROM python:3.11.3-slim as production

IntegrationTests.Dockerfile
1:FROM python:3.11.3-slim as build
20:FROM python:3.11.3-slim
  • some versions are pinned to the minor version, and some are pinned to the patch
  • sometimes the versions drift. In the output above, we can see that the Dockerfile Python versions are at 3.11.3, while the cimg tags are at 3.11.2. At the time of writing this issue, there is no cimg/python:3.11.3 tag

We should ensure internal consistency for these various Python versions, if possible. We should also alert ourselves when things drift out of sync.

@leplatrem
Copy link
Contributor

I put pyproject.toml:python = ">=3.11, <3.13" in #514

But since the container is 3.12, maybe it wouldn't be a bad idea to force the developers to use the same version, even though there's no real obligation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants