Use poetry for dependency management #394
Conversation
One consequence of this was to downgrade pytest to 6.x for unit tests
|
YES 🤩 |
| @@ -233,17 +233,14 @@ jobs: | |||
|
|
|||
| unit_test: | |||
| docker: | |||
| - image: python:3.10.5-bullseye@sha256:dac61c6d3e7ac6deb2926dd96d38090dcba0cb1cf9196ccc5740f25ebe449f50 | |||
| - image: cimg/python:3.11.2 | |||
There was a problem hiding this comment.
is there a tag cimg/python:3.11? ie. do we want to tag minor here?
There was a problem hiding this comment.
There is, but I thought it'd be good to make sure we use the same patch version that we use in our Dockerfile. Or is that being too careful?
There was a problem hiding this comment.
Being careful is good :) I was thinking that we could have a test that verifies that both versions are in sync. I doubt that dependabot will upgrade this line. Will it?
There was a problem hiding this comment.
Yeah, I don't think it will update this line.
We're actually in an interesting situation now where there's a python:3.11.3 published, but there isn't a cimg/python:3.11.3 yet
|
|
||
| # though we have kinto-remote-settings specified as a dependency in | ||
| # pyproject.toml, we have it configured to install in editable mode for local | ||
| # development. For building the container, we only install the "main" |
There was a problem hiding this comment.
in editable mode for local development
because we use --no-root in make install? and develop = true in pyproject.toml?
There was a problem hiding this comment.
I think develop = true is more important than --no-root in this context
Migrate from
pip-toolsto Poetry for dependency managementor move linting / tests to GHA