-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyboard lock (harmful). #353
base: main
Are you sure you want to change the base?
Conversation
This adds it as a harmful position, although it could also be written as a defer position based on the feedback in mozilla#196. Closes mozilla#196.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. The UX concerns noted in Issue #196 are sufficient to mark the current proposal as harmful. Significant changes to address those concerns would be sufficient to bring this back for re-evaluation.
We're doing some thinking about the right way to approach this API and the associated use-cases, will circle back. |
To be more clear about this, we think that this is a reasonable use case, but it might be a poor implementation of that use case. It might be better to defer for now. |
I'm pretty hesitant to take the "good use case, harmful proposal" situation and call it anything other than harmful. Most of our "harmful" designations could be described that way. We've seen other positions in this repository construed completely without nuance in other venues, so I think it's important that we mark things clearly as "harmful" if the currently written-down mechanism is harmful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This: "mark things clearly as "harmful" if the currently written-down mechanism is harmful".
IMO merge it. It's worth getting on the record the current state, regardless of what the potential state might be in some theoretical optimistic future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text looks good. Ship it.
The team that is responsible for this has this on their backlog; let's hold this until we collect their input. |
This adds it as a harmful position, although it could also be written as
a defer position based on the feedback in #196.
Closes #196.