Add UserActivation (positive) #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tantek
previously requested changes
Oct 2, 2023
There was a problem hiding this comment.
Accurately reflects our review and links look good.
One nit, the "description" is a bit tautological (depends on the same phrase as the API name to describe it). It should instead use more descriptive language, such as the phrase "real user interaction" from the Explainer, something like:
The UserActivation API provides the ability to query whether the window currently has or has previously had real user interaction.
zcorpan
commented
Oct 2, 2023
|
@tantek thx, fixed |
martinthomson
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #838