Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Related Projects. #325

Merged
merged 2 commits into from
Aug 17, 2024
Merged

update Related Projects. #325

merged 2 commits into from
Aug 17, 2024

Conversation

wolfgitpr
Copy link
Contributor

@wolfgitpr wolfgitpr commented Aug 15, 2024

PR 描述

添加cpp-pinyin链接(接口参考python-pinyin,算法不同、准确率更高一些)

待办事项

  • 符合代码规范
  • 单元测试
  • 文档

测试环境

cpu i3-8100
python 3.10
pypinyin 0.52.0
cpp-pinyin tests

带声调转换测试

测试集来源——cpp_dataset,约7万9千句

pypinyin:

res = [x[0] for x in pypinyin.pinyin(raw, style=pypinyin.Style.TONE3, neutral_tone_with_five=True)]

pypinyin-tone

cpp-pinyin:
cpp-pinyin-tone

无声调转换测试

测试集来源——多份歌词数据集,人工校对,约2万1千句、19万字

pypinyin:

res = [x[0] for x in pypinyin.pinyin(raw, style=pypinyin.Style.NORMAL, neutral_tone_with_five=True)]

pypinyin-unTone

cpp-pinyin:
cpp-pinyin-unTone

Copy link
Owner

@mozillazg mozillazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

提了个小建议。

README.rst Outdated Show resolved Hide resolved
README_en.rst Outdated Show resolved Hide resolved
README_ru.rst Outdated Show resolved Hide resolved
README_ru.rst Outdated Show resolved Hide resolved
@wolfgitpr
Copy link
Contributor Author

提了个小建议。

好的,感谢指正。

@wolfgitpr
Copy link
Contributor Author

已修改。

Copy link
Owner

@mozillazg mozillazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution!

@mozillazg mozillazg merged commit 0110225 into mozillazg:develop Aug 17, 2024
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants