Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use replaceSkuWithProductName #101

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

feat: Use replaceSkuWithProductName #101

wants to merge 1 commit into from

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

  • Use new server setting rather than webs

Testing Plan

  • Tested in simulator

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Nov 13, 2024
rmi22186
rmi22186 approved these changes Nov 14, 2024
View reviewed changes
Copy link

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. but let's wait for the SQL change to merge first before merging just in case something happens to the setting name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

@samdozor samdozor samdozor approved these changes

@einsteinx2 einsteinx2 Awaiting requested review from einsteinx2

Assignees

@BrandonStalnaker BrandonStalnaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrandonStalnaker @samdozor @rmi22186