#205 Move to System.Text.Json from Newtonsoft #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepki
reviewed
May 27, 2024
| return result; | ||
| } | ||
|
|
||
| public static bool IsPotentialJson(string msg) | ||
| { | ||
| string trimmedMsg = msg.Trim(); | ||
| return (trimmedMsg.StartsWith("{") && trimmedMsg.EndsWith("}")); | ||
| return (trimmedMsg.StartsWith("{") && trimmedMsg.EndsWith("}")); |
There was a problem hiding this comment.
Maybe you could revert these formatting changes (adding/removing whitespaces) from this file as well as the .nuspec files. Without it the PR is more concise and clear.
There was a problem hiding this comment.
@mperdeck to help this along should I bother or are you happy to review it with the whitespace changes? Effectively without the whitespace there is only 3 Additions & 3 removals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the current newtonsoft implementation with System.Text.Json
Closes #205