WIP: Make installable module #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgalery
reviewed
Oct 1, 2020
setup.py
Outdated
| 'treelib', | ||
| 'pymining' | ||
| ] | ||
| ) |
There was a problem hiding this comment.
note that treelib should be locked to version <=1.5.5. I wonder whether deps in environment.yml should be part of this as well, e.g. pandas needs to be locked otherwise things break.
tgalery
reviewed
Oct 1, 2020
setup.py
Outdated
| @@ -23,18 +23,18 @@ | |||
| 'treelib<=1.5.5', | |||
| 'pymining', | |||
| 'sklearn', | |||
| 'git+https://github.com/maciejkula/spotlight.git', | |||
| 'spotlight @ git+git://github.com/maciejkula/spotlight.git@v0.1.6#egg=spotlight', | |||
There was a problem hiding this comment.
I think you don't need to install spotlight here, do you ?It's only developed by a recommender we do in house, and if we port that to this repo, we would do as part of a separate pr.
stathischaritos
force-pushed
the
master
branch
2 times, most recently
from
d847b13
to
5fcec84
Compare
fixing notebooks + setup deps
Add init to markov util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting a pr to make this installable as per
#9