Qualify package names #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffeaton
requested changes
Mar 14, 2024
| @@ -11,6 +11,8 @@ Imports: | |||
| epp (>= 0.4.1), | |||
| fastmatch (>= 1.1), | |||
| mvtnorm, | |||
| plyr, | |||
There was a problem hiding this comment.
Where is plyr used? I don't have recollection of using that.
There was a problem hiding this comment.
Looks like this is only used in 1 place actually, https://github.com/mrc-ide/eppasm/blob/master/R/read-spectrum-pop1.R#L43
There was a problem hiding this comment.
hmmm, not really needed there. but not worth the effort to unwind it!
Good shout, I've updated that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to add github actions to naomi (instead of using buildkite)
That is raising an error because a call in this package can't find
unzipfunction see https://github.com/mrc-ide/naomi/actions/runs/8283097208/job/22665482224?pr=433#step:8:7663or with
setNamesfunction https://github.com/mrc-ide/naomi/actions/runs/8283701894/job/22667510478?pr=433#step:7:7661This PR qualifies all package names which were being raised in an R CMD note. Regenerated the docs, added some missing imports into the DESCRIPTION. I have removed the old
.travis.ymlwhilst I was here as that is no longer used.