Use strict naming for R internal functions to fix compilation R devl #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches over to use full names of R internal functions as the short names are now causing compilation errors on development R (4.5.0)
Example failure https://github.com/hivtools/hintr/actions/runs/11897119041/job/33167243470?pr=538#step:6:8176
See the note for Nov 10th https://developer.r-project.org/blosxom.cgi/R-devel
You can see the compilation failures locally by setting the
-DR_NO_REMAP
flag locally.This fixes compilation, but there are a couple of warning still it would be nice to fix.
The only changes here should be prepending R functions with
Rf_
(there are some whitespace changes introduced automatically on save, better to review the changes ignoring whitespace)