Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strict naming for R internal functions to fix compilation R devl #45

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

r-ash
Copy link
Collaborator

@r-ash r-ash commented Nov 18, 2024

This PR switches over to use full names of R internal functions as the short names are now causing compilation errors on development R (4.5.0)

Example failure https://github.com/hivtools/hintr/actions/runs/11897119041/job/33167243470?pr=538#step:6:8176

See the note for Nov 10th https://developer.r-project.org/blosxom.cgi/R-devel

‘R CMD INSTALL’ (and hence ‘check’) now by default compile C++ code with ‘-DR_NO_REMAP’. For the time being this can be reverted by setting environment variable‘R_CXX_USE_NO_REMAP’ to a false value (but that will be removed in the near future).

You can see the compilation failures locally by setting the -DR_NO_REMAP flag locally.

This fixes compilation, but there are a couple of warning still it would be nice to fix.

The only changes here should be prepending R functions with Rf_ (there are some whitespace changes introduced automatically on save, better to review the changes ignoring whitespace)

@r-ash r-ash requested a review from jeffeaton November 18, 2024 22:58
Copy link
Collaborator

@jeffeaton jeffeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sifting through this; looks good

@r-ash r-ash merged commit 25494ec into master Nov 19, 2024
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants