Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-generate documentation files. #188

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Re-generate documentation files. #188

merged 1 commit into from
Feb 28, 2024

Conversation

plietar
Copy link
Member

@plietar plietar commented Feb 27, 2024

I changed a function signature in #180, but had not regenerated the .Rd files.

I changed a function signature in mrc-ide#180, but had not
regenerated the `.Rd` files.
@plietar plietar requested a review from giovannic February 27, 2024 14:39
@plietar
Copy link
Member Author

plietar commented Feb 27, 2024

We should maybe have a CI check that the docs are up-to-date to avoid this issue in the future. Surprisingly I can't find any precedent of people doing this I can copy.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (c9cdee3) to head (871988c).
Report is 14 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #188      +/-   ##
==========================================
- Coverage   96.28%   96.27%   -0.02%     
==========================================
  Files          36       36              
  Lines        1722     1824     +102     
==========================================
+ Hits         1658     1756      +98     
- Misses         64       68       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@giovannic giovannic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, R CMD Check should normally catch these issues with a warning. My guess is ROxygen's poor R6 support...

@plietar plietar merged commit ba5052a into mrc-ide:dev Feb 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants