Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboard Pagination #246

Closed
wants to merge 3 commits into from

Conversation

chambaz
Copy link
Contributor

@chambaz chambaz commented Sep 26, 2023

This PR adds scroll based pagination to the leaderboard table.

A few notes:

  • The leaderboard table would benefit from improved loading states, both initial load and subsequent scroll triggered loads. Adding skeleton cells would require major refactoring of the component and would be best as a separate pr
  • Currently I cannot authenticate locally and so this PR does not support jumping to user's position in the table, again can be handled in a separate pr
  • The fetchLeaderboardData function did not seem to be used anywhere else, however I want to confirm that as the signature has changed and if so can be reverted for a more backwards compatible version.

@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marginfi-landing-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 11:36pm

@vercel
Copy link

vercel bot commented Sep 26, 2023

@chambaz is attempting to deploy a commit to the mrgn Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant