Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mfi-v2-ui): leaderboard pagination #249

Closed
wants to merge 6 commits into from

Conversation

chambaz
Copy link
Contributor

@chambaz chambaz commented Sep 27, 2023

This PR adds scroll based pagination to the leaderboard table.

I am currently unable to authenticate locally and therefore this PR has not been tested against database to validate and confirm leaderboard positions.

Potential future improvements

  • Jump to user's rank in leaderboard table
  • Fetch domain names async for faster page load, wallet addresses can be overwritten incrementally
  • Load all button (will take time but user initiated action so can be managed)

@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marginfi-landing-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 8:17pm

@vercel
Copy link

vercel bot commented Sep 27, 2023

@chambaz is attempting to deploy a commit to the mrgn Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant