Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mfi-v2-ui): new and improved toast notifications #346

Merged
merged 8 commits into from
Nov 19, 2023

Conversation

losman0s
Copy link
Member

@losman0s losman0s commented Nov 17, 2023

WIP

  • add parsing of errors from log + matching to predefined, explicitly supported programs respective error maps. Supported currently: only mfi-v2 and token. To be extended ad-hoc as we detect fallthrough errors encountered by users. On this note, setting up Sentry to logs and notify those automatically would be A+
  • introduce custom toasts

@losman0s losman0s requested a review from chambaz as a code owner November 17, 2023 14:56
Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marginfi-landing-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2023 8:34pm
marginfi-v2-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2023 8:34pm
omni ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2023 8:34pm

Copy link

alwaysmeticulous bot commented Nov 17, 2023

🤖 Meticulous replayed 50 user sessions and took 237 visual snapshots. Meticulous has not yet run on a324b85 of the main branch and so there was nothing to compare against.

If you recently setup Meticulous, this is expected. Meticulous will start reporting comparisons for new pull requests after the next commit to the main branch.

Last updated for commit 3bd76c6. This comment will update as new commits are pushed.

@chambaz chambaz changed the title Man0s/error handling feat(mfi-v2-ui): new and improved toast notifications Nov 17, 2023
@losman0s losman0s force-pushed the man0s/error-handling branch from 7d7d633 to e2b81ca Compare November 19, 2023 11:42
@chambaz chambaz force-pushed the man0s/error-handling branch from e2b81ca to dc11f5f Compare November 19, 2023 18:18
@chambaz chambaz force-pushed the man0s/error-handling branch from dc11f5f to 41b95ce Compare November 19, 2023 18:39
@chambaz chambaz force-pushed the man0s/error-handling branch from 41b95ce to c26bb26 Compare November 19, 2023 19:08
@chambaz chambaz marked this pull request as ready for review November 19, 2023 19:09
@chambaz chambaz force-pushed the man0s/error-handling branch from c26bb26 to 513f8ce Compare November 19, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants