Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mfi-v2-ui): add liquidation price to position data #369

Merged
merged 19 commits into from
Nov 28, 2023

Conversation

losman0s
Copy link
Member

For @chambaz attention, since I'm not able to get the inline row design done in reasonable time.

The tentative liquidation price is available in the position data.
It is null to signify that there is no liquidation risk (== no liability), otherwise a number.

Remaining work is to display the position data in each row, when extended bank info it active.

Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marginfi-v2-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 3:46pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
marginfi-landing-page ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2023 3:46pm
omni ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2023 3:46pm

Copy link

alwaysmeticulous bot commented Nov 23, 2023

🤖 Meticulous spotted visual differences in 79 of 231 screens tested: view and approve differences detected.

Last updated for commit 16fd046. This comment will update as new commits are pushed.

@chambaz chambaz changed the title feat: add liquidation price to position data feat(mfi-v2-ui): add liquidation price to position data Nov 27, 2023
@chambaz chambaz marked this pull request as ready for review November 27, 2023 20:49
@chambaz chambaz self-requested a review as a code owner November 27, 2023 20:49
@chambaz chambaz merged commit 43ab242 into main Nov 28, 2023
4 of 5 checks passed
@chambaz chambaz deleted the feature/inline-positions branch November 28, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants