-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mfi-v2-ui): add liquidation price to position data #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
🤖 Meticulous spotted visual differences in 79 of 231 screens tested: view and approve differences detected. Last updated for commit 16fd046. This comment will update as new commits are pushed. |
chambaz
force-pushed
the
feature/inline-positions
branch
from
November 25, 2023 01:12
766084b
to
b20e346
Compare
chambaz
force-pushed
the
feature/inline-positions
branch
from
November 27, 2023 15:27
1d20c04
to
2742026
Compare
chambaz
changed the title
feat: add liquidation price to position data
feat(mfi-v2-ui): add liquidation price to position data
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For @chambaz attention, since I'm not able to get the inline row design done in reasonable time.
The tentative liquidation price is available in the
position
data.It is
null
to signify that there is no liquidation risk (== no liability), otherwise anumber
.Remaining work is to display the position data in each row, when extended bank info it active.