Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mfi-v2-ui): new asset banner fixes / improvements #375

Merged
merged 3 commits into from
Nov 25, 2023
Merged

fix(mfi-v2-ui): new asset banner fixes / improvements #375

merged 3 commits into from
Nov 25, 2023

Conversation

chambaz
Copy link
Contributor

@chambaz chambaz commented Nov 25, 2023

  • chore: change name of asset banner local storage val
  • fix: add asset-row data attr to mobile asset cards to fix scroll / highlight
  • chore: remove debugs

@chambaz chambaz requested a review from losman0s as a code owner November 25, 2023 01:06
@vercel Vercel
Copy link

vercel bot commented Nov 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marginfi-landing-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2023 1:09am
marginfi-v2-ui 🛑 Canceled (Inspect) Nov 25, 2023 1:09am
omni ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2023 1:09am

@chambaz chambaz merged commit 1e244b9 into main Nov 25, 2023
2 of 5 checks passed
@chambaz chambaz deleted the fix/new-asset-banner-mobile branch November 25, 2023 01:06
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-ui November 25, 2023 01:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losman0s losman0s Awaiting requested review from losman0s losman0s is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chambaz