Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mfi-v2-ui): reduce only positions #956

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

chambaz
Copy link
Contributor

@chambaz chambaz commented Nov 15, 2024

Checks liability shares instead of usd value to determine if position is lending / borrowing. Fixes reduce only borrows, with 0 state oracles, showing as lending positions unintentionally.

@chambaz chambaz requested a review from losman0s as a code owner November 15, 2024 18:36
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marginfi-landing-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 7:02pm
marginfi-v2-trading ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 7:02pm
marginfi-v2-ui 🛑 Canceled (Inspect) Nov 15, 2024 7:02pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
marginfi-v2-docs ⬜️ Skipped (Inspect) Nov 15, 2024 7:02pm

@vercel vercel bot temporarily deployed to Preview – marginfi-v2-docs November 15, 2024 18:36 Inactive
@chambaz chambaz merged commit e0fc021 into main Nov 15, 2024
4 checks passed
@chambaz chambaz deleted the fix/reduce-only-banks branch November 15, 2024 18:48
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-ui November 15, 2024 19:02 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant