Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mfi-v2-ui): toast improvements #969

Merged
merged 14 commits into from
Nov 27, 2024
Merged

Conversation

borcherd
Copy link
Contributor

@borcherd borcherd commented Nov 25, 2024

Changelog:

  • Various styling changes to the toast (different icon, different loading states, different error message/state)
  • Retry functionality: whenever a transaction fails, a button in the toast appears & are able to re-execute the action from that transaction
  • Dynamic toasts loadingStates depending on broadcast type: if the broadcast type is bundle, it'll update the toast to make it seem like the (possible multiple) transactions are being done in paralel. If the broadcast type is rpc, it'll do them sequentially.
  • Adding explorerUrl to the succeeded transactions: whenever a step is set to success in the toast, it'll also show the explorerUrl (wherever possible)

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marginfi-landing-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 7:47am
marginfi-v2-trading ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 7:47am
marginfi-v2-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 7:47am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
marginfi-v2-docs ⬜️ Skipped (Inspect) Nov 27, 2024 7:47am

@vercel vercel bot temporarily deployed to Preview – marginfi-landing-page November 26, 2024 04:25 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-docs November 26, 2024 04:25 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-docs November 26, 2024 05:25 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-docs November 26, 2024 06:01 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-landing-page November 26, 2024 06:01 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-docs November 26, 2024 15:01 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-landing-page November 26, 2024 15:01 Inactive
Copy link

alwaysmeticulous bot commented Nov 26, 2024

🤖 No test run has been triggered as your Meticulous project has been deactivated (since you haven't viewed any test results in a while). Click here to reactivate.

Last updated for commit 058257d. This comment will update as new commits are pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants