Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mfi-ui): transaction error / warning message copy #973

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

chambaz
Copy link
Contributor

@chambaz chambaz commented Nov 26, 2024

Improved error / warning message copy through simulation, toasts, and action complete dialog

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marginfi-v2-trading 🛑 Canceled (Inspect) Nov 27, 2024 6:09pm
marginfi-v2-ui 🛑 Canceled (Inspect) Nov 27, 2024 6:09pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
marginfi-landing-page ⬜️ Skipped (Inspect) Nov 27, 2024 6:09pm
marginfi-v2-docs ⬜️ Skipped (Inspect) Nov 27, 2024 6:09pm

Copy link

alwaysmeticulous bot commented Nov 26, 2024

Meticulous was unable to execute a test run for this PR because the most recent commit is associated with multiple PRs. To execute a test run, please try pushing up a new commit that is only associated with this PR.

Last updated for commit a54b0bd. This comment will update as new commits are pushed.

@k0beLeenders k0beLeenders force-pushed the chore/error-warning-message-copy branch from 1e606d9 to 5043e29 Compare November 27, 2024 08:15
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-docs November 27, 2024 08:15 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-landing-page November 27, 2024 08:15 Inactive
@chambaz chambaz force-pushed the chore/error-warning-message-copy branch from 5043e29 to b1a204f Compare November 27, 2024 17:43
@vercel vercel bot temporarily deployed to Preview – marginfi-landing-page November 27, 2024 17:43 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-docs November 27, 2024 17:43 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-docs November 27, 2024 18:03 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-landing-page November 27, 2024 18:03 Inactive
@chambaz chambaz marked this pull request as ready for review November 27, 2024 18:03
@chambaz chambaz requested a review from losman0s as a code owner November 27, 2024 18:03
@chambaz chambaz force-pushed the chore/error-warning-message-copy branch from fba347b to 51aa7d6 Compare November 27, 2024 18:08
@vercel vercel bot temporarily deployed to Preview – marginfi-landing-page November 27, 2024 18:08 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-docs November 27, 2024 18:08 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-ui November 27, 2024 18:09 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-trading November 27, 2024 18:09 Inactive
@chambaz chambaz merged commit 6cf317a into develop Nov 27, 2024
3 of 6 checks passed
@chambaz chambaz deleted the chore/error-warning-message-copy branch November 27, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant