Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert UUID_BINARY in PK during update #4

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

mringler
Copy link
Owner

Fixes propelorm#1914 (comment).

I have also changed the UuidConverter, so that it handles null values. The initial idea was to be strict with the type, but it is not robust and lead to ugly code, where the null check has to be performed manually every time.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bf3ebb5) 89.27% compared to head (6b29c6d) 89.35%.
Report is 6 commits behind head on main.

Files Patch % Lines
src/Propel/Generator/Builder/Om/ObjectBuilder.php 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main       #4      +/-   ##
============================================
+ Coverage     89.27%   89.35%   +0.07%     
- Complexity     8049     8062      +13     
============================================
  Files           232      232              
  Lines         24519    24554      +35     
============================================
+ Hits          21889    21939      +50     
+ Misses         2630     2615      -15     
Flag Coverage Δ
5-max 89.35% <93.75%> (+0.07%) ⬆️
7.4 89.35% <93.75%> (+0.07%) ⬆️
agnostic 67.40% <68.75%> (-0.07%) ⬇️
mysql 69.94% <87.50%> (+0.13%) ⬆️
pgsql 69.90% <87.50%> (+0.06%) ⬆️
sqlite 67.87% <87.50%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mringler mringler merged commit 32161c1 into main Nov 28, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant