Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use generative section names in tox.ini #10

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

fghaas
Copy link

@fghaas fghaas commented Oct 10, 2024

By prefixing all our testenvs with the Python version factor ("py311", "py312", etc.), we can ensure that all of our testenvs can be invoked with either Python version being present on the system.

tox will then skip those environments that don't match the Python present on the system, and — provided the remaining environments succeed — return with zero exit code (indicating success).

However, if all environments are skipped, because there is no matching Python version present on the system at all, it returns with a nonzero exit code (indicating failure).

Reference:
https://tox.wiki/en/latest/config.html#generative-section-names

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (drop-python3.8@ce011f6). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                @@
##             drop-python3.8      #10   +/-   ##
=================================================
  Coverage                  ?   95.50%           
=================================================
  Files                     ?       24           
  Lines                     ?     1979           
  Branches                  ?        0           
=================================================
  Hits                      ?     1890           
  Misses                    ?       89           
  Partials                  ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

By prefixing *all* our testenvs with the Python version factor
("py311", "py312", etc.), we can ensure that all of our testenvs can
be invoked with either Python version being present on the system.

tox will then skip those environments that don't match the Python
present on the system, and — provided the remaining environments
succeed — return with a zero exit code (indicating success).

However, if *all* environments are skipped, because there is no
matching Python version present on the system at all, it returns with
a nonzero exit code (indicating failure).

Reference:
https://tox.wiki/en/latest/config.html#generative-section-names
@mrtmm mrtmm merged commit 8e635c4 into mrtmm:drop-python3.8 Oct 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants