Update to Assimp 5.0.1 #367
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thanks Don't worry about the build failed message, it generally happens when submodule is not merged yet. I did plan to update Assimp a while ago, but I do remember on some cases there also was some serious regressions (some models suddenly loading incorrectly) I think I still have those models around, so this will require investigation. |
|
Great, I don't have many models to test, but all of it seems to load just fine. |
|
I forgot to mention, it needs vcredist 2019 installed. Do I need to rebuild using 2015 compiler? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to assimp 5.0.1 https://github.com/assimp/assimp/releases/tag/v5.0.1, many changes since v3, like support for gltf, etc.
Built with VS2019